perf(vite-plugin): load vue transform state only when needed #17935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which also eliminates the need for ui package to be built in the monorepo before running quasar prepare
yusufkandemir
added a commit
to yusufkandemir/quasar
that referenced
this pull request
Mar 26, 2025
which runs quasar prepare, which requires ui package to be built due to logic in vite-plugin removing at least until quasarframework#17935 gets merged
rstoenescu
pushed a commit
that referenced
this pull request
Apr 29, 2025
* chore: migrate to eslint v9 * chore: make more changes for eslint v9 migration * chore: enable cache for eslint * chore(vite-plugin): consolidate eslint config * chore: adjust jsconfig files * chore(docs): remove outdated stylintrc file which was for Stylus * chore: include all projects in VS Code ESLint extension and simplify it by using mode: auto * chore: exclude dist directories from VS Code search * chore: remove failing postinstall script which runs quasar prepare, which requires ui package to be built due to logic in vite-plugin removing at least until #17935 gets merged * chore: rename prepare to prepare:types to avoid unintentional runs forgot prepare was a special script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)Other information:
This is similar to #17756, but for the Vue transform.
I noticed there is still a problem regarding this while working on #17934.
Aside from this use case, it may help with performance with projects that do not have any .vue files and only use .js/.ts files.